From: Emilio Pozuelo Monfort Date: Mon, 1 Jul 2013 16:37:59 +0000 (+0200) Subject: boxpointer: fix left/right arrow side calculation X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3997 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=74cd20116a456e3593e42899cf182c9a7b1be0c5;p=gnome-shell.git boxpointer: fix left/right arrow side calculation Commit d6cace32 introduced a typo in the left/right arrow side calculation code that causes in most scenarios (where the monitor width is greater then the height) to not flip the box when it doesn't fit inside the monitor. https://bugzilla.gnome.org/show_bug.cgi?id=703403 --- diff --git a/js/ui/boxpointer.js b/js/ui/boxpointer.js index 9f85e0254..2fd1a67c3 100644 --- a/js/ui/boxpointer.js +++ b/js/ui/boxpointer.js @@ -589,12 +589,12 @@ const BoxPointer = new Lang.Class({ return St.Side.TOP; break; case St.Side.LEFT: - if (sourceAllocation.y2 + boxWidth > monitor.x + monitor.width && + if (sourceAllocation.x2 + boxWidth > monitor.x + monitor.width && boxWidth < sourceAllocation.x1 - monitor.x) return St.Side.RIGHT; break; case St.Side.RIGHT: - if (sourceAllocation.y1 - boxWidth < monitor.x && + if (sourceAllocation.x1 - boxWidth < monitor.x && boxWidth < monitor.x + monitor.width - sourceAllocation.x2) return St.Side.LEFT; break;